linux-kernel - Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35c97316-1e40-45ed-93b0-7e4f7dbce56d@roeck-us.net>
Date: Wed, 5 Mar 2025 15:03:56 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: George Cherian <george.cherian@...vell.com>, wim@...ux-watchdog.org,
 jwerner@...omium.org, evanbenn@...omium.org, kabel@...nel.org,
 krzk@...nel.org, mazziesaccount@...il.com, thomas.richard@...tlin.com,
 lma@...omium.org, bleung@...omium.org, support.opensource@...semi.com,
 shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
 festevam@...il.com, andy@...nel.org, paul@...pouillou.net,
 alexander.usyskin@...el.com, andreas.werner@....de, daniel@...ngy.jp,
 romain.perier@...il.com, avifishman70@...il.com, tmaimon77@...il.com,
 tali.perry1@...il.com, venture@...gle.com, yuenn@...gle.com,
 benjaminfair@...gle.com, maddy@...ux.ibm.com, mpe@...erman.id.au,
 npiggin@...il.com, christophe.leroy@...roup.eu, naveen@...nel.org,
 mwalle@...nel.org, xingyu.wu@...rfivetech.com, ziv.xu@...rfivetech.com,
 hayashi.kunihiko@...ionext.com, mhiramat@...nel.org
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, chrome-platform@...ts.linux.dev,
 imx@...ts.linux.dev, linux-mips@...r.kernel.org, openbmc@...ts.ozlabs.org,
 linuxppc-dev@...ts.ozlabs.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

On 3/5/25 02:10, George Cherian wrote:
> A new option flag is added to watchdog_info. This helps the watchdog
> core to check whether stop functions would sleep or not.
> The option flags of individual drivers are also updated accordingly.
> 
> Signed-off-by: George Cherian <george.cherian@...vell.com>
> ---
>   drivers/watchdog/advantech_ec_wdt.c | 3 ++-
>   drivers/watchdog/arm_smc_wdt.c      | 3 ++-
>   drivers/watchdog/armada_37xx_wdt.c  | 2 +-


... and many more. Sorry, I didn't expect that this would touch
that many drivers. My bad.

Let's do the opposite instead: Introduce WDIOF_STOP_NOSLEEP,
and let drivers opt in instead of opting out.

I still have to look into the other feedback. I think someone
suggested to introduce a callback instead, which would stop the
watchdog at runtime if needed (especially during kdump).
That may be a better solution than having a module parameter.

Either case, please separate driver patches from the patches
introducing the new flag. Since the flag is opt-in, that should
be ok - drivers supporting it can be modified over time.

Thanks,
Guenter