linux-kernel - Re: [PATCH] iio: imu: bmi270: fix initial sampling frequency configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xvk32vz66mjl46rmrowfb3zxcbuw7e57pn2eh3kvqv5vk3jmuh@45p5qzyl5ljr>
Date: Tue, 4 Mar 2025 23:25:20 -0500
From: Alex Lanzano <lanzano.alex@...il.com>
To: Gustavo Silva <gustavograzs@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>, 
	Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: imu: bmi270: fix initial sampling frequency
 configuration

On Tue, Mar 04, 2025 at 03:01:02PM -0300, Gustavo Silva wrote:
> In the bmi270_configure_imu() function, the accelerometer and gyroscope
> configuration registers are incorrectly written with the mask
> BMI270_PWR_CONF_ADV_PWR_SAVE_MSK, which is unrelated to these registers.
> 
> As a result, the accelerometer's sampling frequency is set to 200 Hz
> instead of the intended 100 Hz.
> 
> Remove the mask to ensure the correct bits are set in the configuration
> registers.
> 
> Signed-off-by: Gustavo Silva <gustavograzs@...il.com>
> ---
>  drivers/iio/imu/bmi270/bmi270_core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/bmi270_core.c
> index a86be5af5ccb1f010f2282ee31c47f284c1bcc86..2e4469f30d538ca3e9eb9ef8bbc6eaa8b6a144b8 100644
> --- a/drivers/iio/imu/bmi270/bmi270_core.c
> +++ b/drivers/iio/imu/bmi270/bmi270_core.c
> @@ -918,8 +918,7 @@ static int bmi270_configure_imu(struct bmi270_data *data)
>  			      FIELD_PREP(BMI270_ACC_CONF_ODR_MSK,
>  					 BMI270_ACC_CONF_ODR_100HZ) |
>  			      FIELD_PREP(BMI270_ACC_CONF_BWP_MSK,
> -					 BMI270_ACC_CONF_BWP_NORMAL_MODE) |
> -			      BMI270_PWR_CONF_ADV_PWR_SAVE_MSK);
> +					 BMI270_ACC_CONF_BWP_NORMAL_MODE));
>  	if (ret)
>  		return dev_err_probe(dev, ret, "Failed to configure accelerometer");
>  
> @@ -927,8 +926,7 @@ static int bmi270_configure_imu(struct bmi270_data *data)
>  			      FIELD_PREP(BMI270_GYR_CONF_ODR_MSK,
>  					 BMI270_GYR_CONF_ODR_200HZ) |
>  			      FIELD_PREP(BMI270_GYR_CONF_BWP_MSK,
> -					 BMI270_GYR_CONF_BWP_NORMAL_MODE) |
> -			      BMI270_PWR_CONF_ADV_PWR_SAVE_MSK);
> +					 BMI270_GYR_CONF_BWP_NORMAL_MODE));
>  	if (ret)
>  		return dev_err_probe(dev, ret, "Failed to configure gyroscope");
>  
> 
> ---
> base-commit: 8cca9edca867350e5f8dc65b71e7a6ef4157981e
> change-id: 20250304-bmi270-odr-fix-620e7f8daa7a
> 

Good catch!

Reviewed-by: Alex Lanzano <lanzano.alex@...il.com>