linux-kernel - RE: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct device state after S4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6098DDEBDF3B7A0160CEBBC2F4CB2@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Wed, 5 Mar 2025 05:48:50 +0000
From: "Xu, Even" <even.xu@...el.com>
To: Jiri Kosina <jikos@...nel.org>
CC: "bentiss@...nel.org" <bentiss@...nel.org>,
	"srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>,
	"mpearson-lenovo@...ebb.ca" <mpearson-lenovo@...ebb.ca>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct
 device state after S4



> -----Original Message-----
> From: Jiri Kosina <jikos@...nel.org>
> Sent: Wednesday, March 5, 2025 1:36 PM
> To: Xu, Even <even.xu@...el.com>
> Cc: bentiss@...nel.org; srinivas.pandruvada@...ux.intel.com; mpearson-
> lenovo@...ebb.ca; linux-input@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: RE: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct device
> state after S4
> 
> On Wed, 5 Mar 2025, Xu, Even wrote:
> 
> > > I'll now apply this as-is because the code is already in, but
> > > perhaps renaming the flag to QUICKI2C_RESET would be in order.
> >
> > Current patch is still needed, quickspi device init flow is: init ->
> > resetting -> reset -> enabled. Exiting code in pm restore() callback
> > takes reset operation and puts device into reset state, but forgets
> > move to enabled state after init flow is done.
> >
> > Thanks for your suggestion! Let me refine the patch in V2.
> 
> I have already applied your v1 patch to upstream-fixes queue so that it could go to
> Linus quickly, as an important functional fix.
> 
> So please base the naming fixup on top of that.

Thanks Jiri!

I didn't realize v1 patch already got applied, just sent out v2 patch this morning.
If so, could you just pick " [PATCH v2 1/2] HID: Intel-thc-hid: Intel-quickspi: Correct device state names gramatically" from v2 patch set for the naming fix?
Those two patches have no confliction/dependence.

Thank you very much!

Best Regards,
Even Xu

> 
> Thanks,
> 
> --
> Jiri Kosina
> SUSE Labs