linux-kernel - Re: [PATCH V3 2/2] mailbox: tmelite-qmp: Introduce TMEL QMP mailbox driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60b2e0d3-bd95-47bf-ab02-edae8b86c392@quicinc.com>
Date: Wed, 5 Mar 2025 13:03:52 +0530
From: Sricharan Ramabadhran <quic_srichara@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Dmitry Baryshkov
	<dmitry.baryshkov@...aro.org>
CC: <jassisinghbrar@...il.com>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <andersson@...nel.org>, <konradybcio@...nel.org>,
        <manivannan.sadhasivam@...aro.org>
Subject: Re: [PATCH V3 2/2] mailbox: tmelite-qmp: Introduce TMEL QMP mailbox
 driver



On 3/4/2025 10:16 PM, Konrad Dybcio wrote:
> On 4.03.2025 10:46 AM, Dmitry Baryshkov wrote:
>> On Tue, 4 Mar 2025 at 10:33, Sricharan Ramabadhran
>> <quic_srichara@...cinc.com> wrote:
>>>
>>>
>>>
>>> On 3/3/2025 6:34 PM, Dmitry Baryshkov wrote:
>>>> On Mon, Mar 03, 2025 at 03:58:42PM +0530, Sricharan Ramabadhran wrote:
>>>>>
>>>>>
>>>>> On 2/28/2025 12:03 PM, Dmitry Baryshkov wrote:
>>>>>> On Fri, Feb 28, 2025 at 10:23:56AM +0530, Sricharan R wrote:
>>>>
>>>>>>> +          dev_err(dev, "Failed with status: %d\n", msg.resp.status);
>>>>>>> +          ret = msg.resp.status;
>>>>>>
>>>>>> return msg.resp.status (is it really errno?)
>>>>>>
>>>>> ok, yes error.
>>>>
>>>> The question was if it is an errno, not if it is an error.
>>> status != 0 is an error always.
>>
>> Is it an _errno_ ?
> 
> Dmitry's asking whether the status conforms to the Linux's errno.h
> ABI. If not, add something like:
> 
> ret = msg.resp.status ? -EINVAL : 0
Yeah, responded on other thread. It does not, so will add the mapping.

Regards,
Sricharan