linux-kernel - Re: [v2] mei: Improve exception handling in mei_cl_irq_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccdac63a-4a04-4243-9350-05acc23f413b@web.de>
Date: Wed, 5 Mar 2025 08:38:30 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Alexander Usyskin <alexander.usyskin@...el.com>,
 kernel-janitors@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: cocci@...ia.fr, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [v2] mei: Improve exception handling in mei_cl_irq_read_msg()

>> The label “discard” was used to jump to another pointer check despite of
>> the detail in the implementation of the function “mei_cl_irq_read_msg”
>> that it was determined already that a corresponding variable contained
>> a null pointer.
>>
>> * Thus use an additional label instead.
>>
>> * Delete a redundant check.
…
>> +move_tail:
>
> In general, why not, but the label naming is bad.
> It hides the original intent to discard this message.
> Let's rename existing label to discard_nocb: and leave a new one as discard:.
> Also, the patch will be smaller in this way.

Do you expect a third patch version according to your naming preferences?

Regards,
Markus