linux-kernel - RE: [v2] mei: Improve exception handling in mei_cl_irq_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY5PR11MB6366E6F52B68E8258EE47F3FEDCB2@CY5PR11MB6366.namprd11.prod.outlook.com>
Date: Wed, 5 Mar 2025 07:41:25 +0000
From: "Usyskin, Alexander" <alexander.usyskin@...el.com>
To: Markus Elfring <Markus.Elfring@....de>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>
CC: "cocci@...ia.fr" <cocci@...ia.fr>, LKML <linux-kernel@...r.kernel.org>
Subject: RE: [v2] mei: Improve exception handling in mei_cl_irq_read_msg()

> >
> > In general, why not, but the label naming is bad.
> > It hides the original intent to discard this message.
> > Let's rename existing label to discard_nocb: and leave a new one as discard:.
> > Also, the patch will be smaller in this way.
> 
> Do you expect a third patch version according to your naming preferences?
> 
> Regards,
> Markus

I prefer to, as the current patch reduces this code readability.

- - 
Thanks,
Sasha