linux-kernel - Re: [v2] mei: Improve exception handling in mei_cl_irq_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025030508-iodize-diagram-3e0f@gregkh>
Date: Wed, 5 Mar 2025 08:57:33 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: "Usyskin, Alexander" <alexander.usyskin@...el.com>
Cc: Markus Elfring <Markus.Elfring@....de>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>, "cocci@...ia.fr" <cocci@...ia.fr>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [v2] mei: Improve exception handling in mei_cl_irq_read_msg()

On Wed, Mar 05, 2025 at 07:41:25AM +0000, Usyskin, Alexander wrote:
> > >
> > > In general, why not, but the label naming is bad.
> > > It hides the original intent to discard this message.
> > > Let's rename existing label to discard_nocb: and leave a new one as discard:.
> > > Also, the patch will be smaller in this way.
> > 
> > Do you expect a third patch version according to your naming preferences?
> > 
> > Regards,
> > Markus
> 
> I prefer to, as the current patch reduces this code readability.
> 
> - - 
> Thanks,
> Sasha
> 
> 

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot