linux-kernel - Re: [PATCH v2] platform/x86: samsung-galaxybook: Fix block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f779992-1a3b-475b-b07b-3a4ca02f5b35@gmx.de>
Date: Wed, 5 Mar 2025 01:29:24 +0100
From: Armin Wolf <W_Armin@....de>
To: Joshua Grisham <josh@...huagrisham.com>, thomas@...ch.de,
 kuurtb@...il.com, ilpo.jarvinen@...ux.intel.com, hdegoede@...hat.com,
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86: samsung-galaxybook: Fix block_recording
 not supported logic

Am 03.03.25 um 14:24 schrieb Joshua Grisham:

> Fixes logic error when block_recording is not supported but the fw attr was
> being added anyway (reported by GitHub user bbregeault).
>
> Tested myself on a Samsung Galaxy Book2 Pro (has block_recording) and by
> bbregeault on a Galaxy Book2 Business (does not have block_recording).

For the future you can use Tested-by tags to indicate who tested this patch.
For now:

Reviewed-by: Armin Wolf <W_Armin@....de>

> Fixes: 56f529ce4370 ("platform/x86: samsung-galaxybook: Add samsung-galaxybook driver")
>
> Signed-off-by: Joshua Grisham <josh@...huagrisham.com>
>
> ---
> v1->v2:
> - Add Fixes tag with prior commit (thanks Ilpo for catching!)
> ---
>   drivers/platform/x86/samsung-galaxybook.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x86/samsung-galaxybook.c
> index de1ed2dc6..5878a3519 100644
> --- a/drivers/platform/x86/samsung-galaxybook.c
> +++ b/drivers/platform/x86/samsung-galaxybook.c
> @@ -1100,11 +1100,13 @@ static int galaxybook_fw_attrs_init(struct samsung_galaxybook *galaxybook)
>   	}
>
>   	err = galaxybook_block_recording_init(galaxybook);
> -	if (!err)
> -		galaxybook->has_block_recording = true;
> -	else if (err != GB_NOT_SUPPORTED)
> +	if (err == GB_NOT_SUPPORTED)
> +		return 0;
> +	else if (err)
>   		return err;
>
> +	galaxybook->has_block_recording = true;
> +
>   	return galaxybook_fw_attr_init(galaxybook,
>   				       GB_ATTR_BLOCK_RECORDING,
>   				       &block_recording_acpi_get,