linux-kernel - Re: [PATCH v8 2/4] scanf: remove redundant debug logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8gSiwsSvjl7c4rR@pathway.suse.cz>
Date: Wed, 5 Mar 2025 09:59:55 +0100
From: Petr Mladek <pmladek@...e.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: David Gow <davidgow@...gle.com>, Steven Rostedt <rostedt@...dmis.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Shuah Khan <shuah@...nel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v8 2/4] scanf: remove redundant debug logs

On Fri 2025-02-14 11:19:59, Tamir Duberstein wrote:
> Remove `pr_debug` calls which emit information already contained in
> `pr_warn` calls that occur on test failure. This reduces unhelpful test
> verbosity.
> 
> Note that a `pr_debug` removed from `_check_numbers_template` appears to
> have been the only guard against silent false positives, but in fact
> this condition is handled in `_test`; it is only possible for `n_args`
> to be `0` in `_check_numbers_template` if the test explicitly expects it
> *and* `vsscanf` returns `0`, matching the expectation.
> 
> Signed-off-by: Tamir Duberstein <tamird@...il.com>

I am fine with the change. The debug messages have been obsoleted by
the 1st patch. The file:line information is more convenient to find
the failing test.

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr