linux-kernel - Re: [PATCH] drm/amd/display: fix missing .is_two_pixels_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_PaxnYBeTVaidOVJzqnj_HfQH-xwYwUmf3BVeZOaQeT6g@mail.gmail.com>
Date: Thu, 6 Mar 2025 09:43:47 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Aliaksei Urbanski <aliaksei.urbanski@...il.com>
Cc: Wenjing Liu <wenjing.liu@....com>, Daniel Wheeler <daniel.wheeler@....com>, 
	Alex Deucher <alexander.deucher@....com>, Christian König <christian.koenig@....com>, 
	Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>, 
	amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Rosen Penev <rosenp@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: fix missing .is_two_pixels_per_container

Applied.  Thanks!

On Thu, Mar 6, 2025 at 9:13 AM Aliaksei Urbanski
<aliaksei.urbanski@...il.com> wrote:
>
> Starting from 6.11, AMDGPU driver, while being loaded with amdgpu.dc=1,
> due to lack of .is_two_pixels_per_container function in dce60_tg_funcs,
> causes a NULL pointer dereference on PCs with old GPUs, such as R9 280X.
>
> So this fix adds missing .is_two_pixels_per_container to dce60_tg_funcs.
>
> Reported-by: Rosen Penev <rosenp@...il.com>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3942
> Fixes: e6a901a00822 ("drm/amd/display: use even ODM slice width for two pixels per container")
> Cc: <stable@...r.kernel.org> # 6.11+
> Signed-off-by: Aliaksei Urbanski <aliaksei.urbanski@...il.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce60/dce60_timing_generator.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_timing_generator.c b/drivers/gpu/drm/amd/display/dc/dce60/dce60_timing_generator.c
> index e5fb0e8333..e691a1cf33 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_timing_generator.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_timing_generator.c
> @@ -239,6 +239,7 @@ static const struct timing_generator_funcs dce60_tg_funcs = {
>                                 dce60_timing_generator_enable_advanced_request,
>                 .configure_crc = dce60_configure_crc,
>                 .get_crc = dce110_get_crc,
> +               .is_two_pixels_per_container = dce110_is_two_pixels_per_container,
>  };
>
>  void dce60_timing_generator_construct(
> --
> 2.48.1
>