linux-kernel - Re: [PATCH 1/2] can: flexcan: only set CAN_STATE_ERROR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8m5K5EwiyiYikqL@lizhi-Precision-Tower-5810>
Date: Thu, 6 Mar 2025 10:03:07 -0500
From: Frank Li <Frank.li@....com>
To: haibo.chen@....com
Cc: mkl@...gutronix.de, mailhol.vincent@...adoo.fr,
	ciprianmarian.costea@....nxp.com, han.xu@....com,
	u.kleine-koenig@...libre.com, linux-can@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH 1/2] can: flexcan: only set CAN_STATE_ERROR_ACTIVE when
 resume has no issue

On Thu, Mar 06, 2025 at 02:59:20PM +0800, haibo.chen@....com wrote:
> From: Haibo Chen <haibo.chen@....com>
>
> Only set CAN state to CAN_STATE_ERROR_ACTIVE when resume process has
> no issue, otherwise keep in CAN_STATE_SLEEPING as suspend did.
>
> Signed-off-by: Haibo Chen <haibo.chen@....com>

Reviewed-by: Frank Li <Frank.Li@....com>

> ---
>  drivers/net/can/flexcan/flexcan-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
> index b347a1c93536..8415ef71f1b1 100644
> --- a/drivers/net/can/flexcan/flexcan-core.c
> +++ b/drivers/net/can/flexcan/flexcan-core.c
> @@ -2311,7 +2311,6 @@ static int __maybe_unused flexcan_resume(struct device *device)
>  	struct flexcan_priv *priv = netdev_priv(dev);
>  	int err;
>
> -	priv->can.state = CAN_STATE_ERROR_ACTIVE;
>  	if (netif_running(dev)) {
>  		netif_device_attach(dev);
>  		netif_start_queue(dev);
> @@ -2332,6 +2331,7 @@ static int __maybe_unused flexcan_resume(struct device *device)
>  			flexcan_chip_interrupts_enable(dev);
>  		}
>  	}
> +	priv->can.state = CAN_STATE_ERROR_ACTIVE;
>
>  	return 0;
>  }
> --
> 2.34.1
>