linux-kernel - Re: [PATCH v2 2/2] can: flexcan: disable transceiver during system PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8m5cCC597WZq8uO@lizhi-Precision-Tower-5810>
Date: Thu, 6 Mar 2025 10:04:16 -0500
From: Frank Li <Frank.li@....com>
To: haibo.chen@....com
Cc: mkl@...gutronix.de, mailhol.vincent@...adoo.fr,
	ciprianmarian.costea@....nxp.com, han.xu@....com,
	u.kleine-koenig@...libre.com, linux-can@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH v2 2/2] can: flexcan: disable transceiver during system PM

On Thu, Mar 06, 2025 at 02:59:21PM +0800, haibo.chen@....com wrote:
> From: Haibo Chen <haibo.chen@....com>
>
> During system PM, if no wakeup requirement, disable transceiver to
> save power.
>
> Signed-off-by: Haibo Chen <haibo.chen@....com>

Reviewed-by: Frank Li <Frank.Li@....com>

> ---
> Changes for V2:
> - add return check for flexcan_transceiver_disable
> - disable transceiver if flexcan_chip_start() failed
> ---
>  drivers/net/can/flexcan/flexcan-core.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
> index 8415ef71f1b1..6c59c2cfcf05 100644
> --- a/drivers/net/can/flexcan/flexcan-core.c
> +++ b/drivers/net/can/flexcan/flexcan-core.c
> @@ -2292,6 +2292,9 @@ static int __maybe_unused flexcan_suspend(struct device *device)
>  				return err;
>
>  			flexcan_chip_interrupts_disable(dev);
> +			err = flexcan_transceiver_disable(priv);
> +			if (err)
> +				return err;
>
>  			err = pinctrl_pm_select_sleep_state(device);
>  			if (err)
> @@ -2324,10 +2327,16 @@ static int __maybe_unused flexcan_resume(struct device *device)
>  			if (err)
>  				return err;
>
> -			err = flexcan_chip_start(dev);
> +			err = flexcan_transceiver_enable(priv);
>  			if (err)
>  				return err;
>
> +			err = flexcan_chip_start(dev);
> +			if (err) {
> +				flexcan_transceiver_disable(priv);
> +				return err;
> +			}
> +
>  			flexcan_chip_interrupts_enable(dev);
>  		}
>  	}
> --
> 2.34.1
>