linux-kernel - Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nXzY_j38ytE7KwHpH3Cy4sDw85WU2MyUe5u74oB2UP+Q@mail.gmail.com>
Date: Thu, 6 Mar 2025 17:36:05 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
Cc: a.hindborg@...nel.org, alex.gaynor@...il.com, aliceryhl@...gle.com, 
	apw@...onical.com, arnd@...db.de, aswinunni01@...il.com, axboe@...nel.dk, 
	benno.lossin@...ton.me, bhelgaas@...gle.com, bjorn3_gh@...tonmail.com, 
	boqun.feng@...il.com, dakr@...nel.org, dwaipayanray1@...il.com, 
	ethan.twardy@...il.com, fujita.tomonori@...il.com, gary@...yguo.net, 
	gregkh@...uxfoundation.org, joe@...ches.com, linux-kernel@...r.kernel.org, 
	lukas.bulwahn@...il.com, ojeda@...nel.org, pbonzini@...hat.com, 
	rust-for-linux@...r.kernel.org, tmgross@...ch.edu, walmeida@...rosoft.com
Subject: Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules

On Thu, Mar 6, 2025 at 5:08 PM Guilherme Giacomo Simoes
<trintaeoitogc@...il.com> wrote:
>
> In current config, the formatting seems don't have a effect for arrays.
> i.e. this array: authors: [ "author_1", "author_2", "author_3", "author_4","author_5","author_6","author_7" ]
> don't is fixed by rustfmt for no format.

So if I understand correctly, `rustfmt` will simply not do anything,
i.e. it will always keep the array as it was -- that sounds good
enough to me! Most people will write it correctly, and for those that
don't, `checkpatch.pl` will likely catch the mistake -- that is all we
need.

Cheers,
Miguel