linux-kernel - Re: [PATCH v2 1/5] tools/nolibc: add support for openat(2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <598c8370-507b-4d6f-bf7e-ce17a3b5dca0@t-8ch.de>
Date: Thu, 6 Mar 2025 18:22:45 +0100
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Willy Tarreau <w@....eu>
Cc: Louis Taylor <louis@...gniz.eu>, Shuah Khan <shuah@...nel.org>, 
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 1/5] tools/nolibc: add support for openat(2)

Hi Willy,

On 2025-03-04 09:11:16+0100, Willy Tarreau wrote:
> On Tue, Mar 04, 2025 at 07:58:15AM +0000, Louis Taylor wrote:
> > openat is useful to avoid needing to construct relative paths, so expose
> > a wrapper for using it directly.
> 
> Reviewed the whole series, no comments from me. Let's wait for Thomas
> to double-check but for me it's OK:
> 
> Acked-by: Willy Tarreau <w@....eu>

Fairly happy with it, only some tiny nitpicks.

> Thomas, since you already have plenty of changes in queue, do you mind
> if I let you pick this series ?

Sure.

Also we need to send a PR to Shuah soon.
I have some patches I want to get into it.
In case you missed it:
https://lore.kernel.org/lkml/20250305-nolibc-asm-headers-v1-1-f2053def2ee7@linutronix.de/
Also the removal of the constructor order validation.
Will you send a patch or should I?


Thomas