linux-kernel - Re: [PATCH v2 1/5] tools/nolibc: add support for openat(2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250306174207.GD23569@1wt.eu>
Date: Thu, 6 Mar 2025 18:42:07 +0100
From: Willy Tarreau <w@....eu>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Louis Taylor <louis@...gniz.eu>, Shuah Khan <shuah@...nel.org>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 1/5] tools/nolibc: add support for openat(2)

Hi Thomas,

On Thu, Mar 06, 2025 at 06:22:45PM +0100, Thomas Weißschuh wrote:
> Hi Willy,
> 
> On 2025-03-04 09:11:16+0100, Willy Tarreau wrote:
> > On Tue, Mar 04, 2025 at 07:58:15AM +0000, Louis Taylor wrote:
> > > openat is useful to avoid needing to construct relative paths, so expose
> > > a wrapper for using it directly.
> > 
> > Reviewed the whole series, no comments from me. Let's wait for Thomas
> > to double-check but for me it's OK:
> > 
> > Acked-by: Willy Tarreau <w@....eu>
> 
> Fairly happy with it, only some tiny nitpicks.

Thanks for double-checking, you caught way more things than me!

> > Thomas, since you already have plenty of changes in queue, do you mind
> > if I let you pick this series ?
> 
> Sure.
> 
> Also we need to send a PR to Shuah soon.
> I have some patches I want to get into it.
> In case you missed it:
> https://lore.kernel.org/lkml/20250305-nolibc-asm-headers-v1-1-f2053def2ee7@linutronix.de/

Yes I noticed them, these days I'm totally overwhelmed and tend to only
be able to have a look at them during my week-ends :-(

> Also the removal of the constructor order validation.

Yes, not sure I'll have time for it yet :-( I can try, though!

> Will you send a patch or should I?

As last time it will greatly help me if you take care of it. I
feel like I'm leaving you with all the work these days :-/

Cheers,
Willy