linux-kernel - RE: [EXTERNAL] Re: [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add reset controller node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BY3PR18MB4673BD07048F8AF7EA55282CA7CA2@BY3PR18MB4673.namprd18.prod.outlook.com>
Date: Thu, 6 Mar 2025 17:42:56 +0000
From: Wilson Ding <dingwei@...vell.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "robh@...nel.org" <robh@...nel.org>
CC: "andrew@...n.ch" <andrew@...n.ch>,
        "gregory.clement@...tlin.com"
	<gregory.clement@...tlin.com>,
        "sebastian.hesselbarth@...il.com"
	<sebastian.hesselbarth@...il.com>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>,
        Sanghoon Lee <salee@...vell.com>,
        Geethasowjanya
 Akula <gakula@...vell.com>
Subject: RE: [EXTERNAL] Re: [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add
 reset controller node



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Wednesday, March 5, 2025 11:29 PM
> To: Wilson Ding <dingwei@...vell.com>; linux-kernel@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> robh@...nel.org
> Cc: andrew@...n.ch; gregory.clement@...tlin.com;
> sebastian.hesselbarth@...il.com; krzk+dt@...nel.org; conor+dt@...nel.org;
> p.zabel@...gutronix.de; Sanghoon Lee <salee@...vell.com>;
> Geethasowjanya Akula <gakula@...vell.com>
> Subject: [EXTERNAL] Re: [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add reset
> controller node
> 
> On 04/03/2025 20:08, Wilson Ding wrote:
> >
> > I did consider shrinking the syscon's register address range to make
> > the reset-controller node to be independent from the syscon node.
> > However, I found the syscon node is also referred by some devices for
> > miscellaneous configurations . The reset configuration register
> > happens to be located in between these registers and clock/GPIO
> > registers.
> >
> >> drop offset in your patch or unify everything into 'reg'.
> >>
> >
> > This is exactly what I proposed in v3 patch. Do I misunderstand you?
> >
> > CP11X_LABEL(swrst): reset-controller@268 {
> > 	compatible = "marvell,armada8k-reset";
> > 	reg = <0x268 0x4>;
> > 	#reset-cells = <1>;
> > };
> 
> I don't see the other device being fixed here. How did you unify them?

This patch series is about the proposal of Armada8K's reset controller
dt-binding. The dt-bindings issues of clock/GPIO controllers have been
there for years. Having to say, it is not just a simple patch to fix it. It
will require to convert the dt-binding document into json schemas as
well as adapt these dt changes in the drivers. So I would suggest to
fixing it in later patches. How do you think about it?

> 
> Best regards,
> Krzysztof