linux-kernel - Re: [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add reset controller node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03b14353-5d47-48de-99fd-9cc48bad5651@kernel.org>
Date: Thu, 6 Mar 2025 08:29:06 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wilson Ding <dingwei@...vell.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>, "robh@...nel.org" <robh@...nel.org>
Cc: "andrew@...n.ch" <andrew@...n.ch>,
 "gregory.clement@...tlin.com" <gregory.clement@...tlin.com>,
 "sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
 Sanghoon Lee <salee@...vell.com>, Geethasowjanya Akula <gakula@...vell.com>
Subject: Re: [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add reset controller
 node

On 04/03/2025 20:08, Wilson Ding wrote:
> 
> I did consider shrinking the syscon's register address range to
> make the reset-controller node to be independent from the
> syscon node. However, I found the syscon node is also referred
> by some devices for miscellaneous configurations . The reset
> configuration register happens to be located in between these
> registers and clock/GPIO registers.
> 
>> drop offset in your patch or unify everything into 'reg'.
>>
> 
> This is exactly what I proposed in v3 patch. Do I misunderstand
> you?
> 
> CP11X_LABEL(swrst): reset-controller@268 {
> 	compatible = "marvell,armada8k-reset";
> 	reg = <0x268 0x4>;
> 	#reset-cells = <1>;
> };

I don't see the other device being fixed here. How did you unify them?

Best regards,
Krzysztof