linux-kernel - Re: [PATCH] nvme: remove multipath module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8jpFkHsN94nVgEf@kbusch-mbp>
Date: Wed, 5 Mar 2025 17:15:18 -0700
From: Keith Busch <kbusch@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: Hannes Reinecke <hare@...e.de>, Sagi Grimberg <sagi@...mberg.me>,
	Nilay Shroff <nilay@...ux.ibm.com>,
	John Meneghini <jmeneghi@...hat.com>, bmarzins@...hat.com,
	Bryan Gurney <bgurney@...hat.com>, linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Marco Patalano <mpatalan@...hat.com>,
	axboe@...nel.dk
Subject: Re: [PATCH] nvme: remove multipath module parameter

On Thu, Mar 06, 2025 at 01:03:48AM +0100, Christoph Hellwig wrote:
> On Wed, Mar 05, 2025 at 04:57:44PM -0700, Keith Busch wrote:
> > In my experience, it's left enabled because of SRIOV, which many of
> > these devices end up shipping without supporting in PCI space anyway.
> 
> If a device supports SR-IO setting CMIC and NMIC is corret, but I've
> actually seen surprisingly few production controllers actually supporting
> SR-IOV despite what the datasheets say.

And I bet at least some of those devices left their {C,N}MIC bits on
despite not even supporting the virtual functions in their shipping
product.
 
> > Not quite the same thing, but kind of related: I proposed this device
> > missing debounce thing about a year ago:
> > 
> > https://lore.kernel.org/linux-nvme/Y+1aKcQgbskA2tra@kbusch-mbp.dhcp.thefacebook.com/
> 
> Yes, that somehow fell off the cliff.

I'll be happy to revive it, but I don't know how much time I can
dedicate to seeing it across the line.