linux-kernel - Re: [PATCH] nvme: remove multipath module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ffebf60-5672-4cd0-bb5a-934376c16694@suse.de>
Date: Thu, 6 Mar 2025 08:12:03 +0100
From: Hannes Reinecke <hare@...e.de>
To: Christoph Hellwig <hch@....de>, Keith Busch <kbusch@...nel.org>
Cc: Sagi Grimberg <sagi@...mberg.me>, Nilay Shroff <nilay@...ux.ibm.com>,
 John Meneghini <jmeneghi@...hat.com>, bmarzins@...hat.com,
 Bryan Gurney <bgurney@...hat.com>, linux-nvme@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Marco Patalano <mpatalan@...hat.com>,
 axboe@...nel.dk
Subject: Re: [PATCH] nvme: remove multipath module parameter

On 3/6/25 01:03, Christoph Hellwig wrote:
> On Wed, Mar 05, 2025 at 04:57:44PM -0700, Keith Busch wrote:
>>>> Obviously he's not talking about multiported PCIe.
>>>
>>> Why is that obvious?
>>
>> No one here would think a multiported device *wouldn't* report CMIC.
> 
> I hopes so.
> 
>> The
>> fact Hannes thinks that's a questionable feature for his device gives
>> away that it is single ported.
> 
> Well, his quote reads like he doesn't know about multiport PCIe devices.
> But maybe he just meant to say "despite being single-ported"
> 
Single ported.
There is a range of Samsung NVMe where one is a normal, single ported,
NVMe, and one with a nearly identical model number reporting CMIC.

Causing _quite_ a lot of confusion with the customer (and L3) when
used under MD, as for the first hotplug works, for the second ... not so 
much.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich