linux-kernel - Re: [PATCH] serial: 8250: Optimize port function assignment with generic macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025030602-frays-profusely-0656@gregkh>
Date: Thu, 6 Mar 2025 08:05:33 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: xiaopeitux@...mail.com
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	xiaopei01 <xiaopei01@...inos.cn>
Subject: Re: [PATCH] serial: 8250: Optimize port function assignment with
 generic macro

On Thu, Mar 06, 2025 at 11:00:32AM +0800, xiaopeitux@...mail.com wrote:
> From: xiaopei01 <xiaopei01@...inos.cn>

Sorry, as per the documentation we need a name, not just an email alias.

> Refactor repetitive conditional function pointer assignments using a
> generic macro ASSIGN_IF_EXIST. This consolidates 15+ conditional
> checks into a consistent pattern while maintaining type safety.

But why?  Macros are a pain and hide what is happening here.  Do you
think this makes the code more maintainable over time?  Does it fix any
existing bugs?

thanks,

greg k-h