linux-kernel - Re: [PATCH] serial: 8250: Optimize port function assignment with generic macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c9ab398-4074-48b8-9606-21c50f057516@kylinos.cn>
Date: Fri, 7 Mar 2025 10:12:53 +0800
From: Pei Xiao <xiaopei01@...inos.cn>
To: Greg KH <gregkh@...uxfoundation.org>, xiaopeitux@...mail.com
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: 8250: Optimize port function assignment with
 generic macro


在 2025/3/6 15:05, Greg KH 写道:
> On Thu, Mar 06, 2025 at 11:00:32AM +0800, xiaopeitux@...mail.com wrote:
>> From: xiaopei01 <xiaopei01@...inos.cn>
> Sorry, as per the documentation we need a name, not just an email alias.

ok，perhaps I changed a new computer to send patch caused it. 

I will modify in next time!

>> Refactor repetitive conditional function pointer assignments using a
>> generic macro ASSIGN_IF_EXIST. This consolidates 15+ conditional
>> checks into a consistent pattern while maintaining type safety.
> But why?  Macros are a pain and hide what is happening here.  Do you
> think this makes the code more maintainable over time?  Does it fix any
> existing bugs?

sorry for make some noise，I know you're a very busy person. 

Sorry for disturbing you！

No,it don't fix any bugs.Indeed, it's less readable than the previous code. 

Initially, I thought there were too many repetitive lines, 

and the code length could be reduced.


thanks！

Pei Xiao

> thanks,
>
> greg k-h