linux-kernel - Re: [PATCH 3/8] ftrace: Move trace sysctls into trace.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dekaemtglzq5el2omrusxyqntdqbzyllcalzor4jrindici25g@x2bdsiblw6iw>
Date: Thu, 6 Mar 2025 11:15:38 +0100
From: Joel Granados <joel.granados@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Kees Cook <kees@...nel.org>, Masami Hiramatsu <mhiramat@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>, 
	Adrian Hunter <adrian.hunter@...el.com>, "Liang, Kan" <kan.liang@...ux.intel.com>, 
	"David S. Miller" <davem@...emloft.net>, Andreas Larsson <andreas@...sler.com>, 
	Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, 
	Alexander Gordeev <agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, 
	Sven Schnelle <svens@...ux.ibm.com>, Gerald Schaefer <gerald.schaefer@...ux.ibm.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, linux-trace-kernel@...r.kernel.org, 
	linux-perf-users@...r.kernel.org, sparclinux@...r.kernel.org, linux-s390@...r.kernel.org, 
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH 3/8] ftrace: Move trace sysctls into trace.c

On Mon, Mar 03, 2025 at 08:44:55PM -0500, Steven Rostedt wrote:
> On Tue, 18 Feb 2025 10:56:19 +0100
> Joel Granados <joel.granados@...nel.org> wrote:
> 
> Nit, change the subject to:
> 
>   tracing: Move trace sysctls into trace.c
Done. Thx for the feedback 

Best
> 
> as I try to only have the "ftrace:" label for modifications that affect
> attaching to functions, and "tracing:" for everything else.
> 
> Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> 
> -- Steve
> 
> 
> > Move trace ctl tables into their own const array in
> > kernel/trace/trace.c. The sysctl table register is called with
> > subsys_initcall placing if after its original place in proc_root_init.
> > This is part of a greater effort to move ctl tables into their
> > respective subsystems which will reduce the merge conflicts in
> > kerenel/sysctl.c.
> > 
> > Signed-off-by: Joel Granados <joel.granados@...nel.org>
> > ---
...
> > +	},
> > +};
> > +
> > +static int __init init_trace_sysctls(void)
> > +{
> > +	register_sysctl_init("kernel", trace_sysctl_table);
> > +	return 0;
> > +}
> > +subsys_initcall(init_trace_sysctls);
> >  
> >  #ifdef CONFIG_TRACE_EVAL_MAP_FILE
> >  /* Map of enums to their values, for "eval_map" file */
> > 
> 

-- 

Joel Granados