linux-kernel - Re: [PATCH] drm/exynos/vidi: Remove redundant error handling in vidi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c29a5d6e-335b-463e-a318-e8d78d176a9f@web.de>
Date: Fri, 7 Mar 2025 15:48:37 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: vulab@...as.ac.cn, dri-devel@...ts.freedesktop.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Alim Akhtar
 <alim.akhtar@...sung.com>, David Airlie <airlied@...il.com>,
 Inki Dae <inki.dae@...sung.com>, Jani Nikula <jani.nikula@...ux.intel.com>,
 Krzysztof Kozlowski <krzk@...nel.org>,
 Kyungmin Park <kyungmin.park@...sung.com>,
 Seung-Woo Kim <sw0312.kim@...sung.com>, Simona Vetter <simona@...ll.ch>
Subject: Re: [PATCH] drm/exynos/vidi: Remove redundant error handling in
 vidi_get_modes()

…
> drm_edid_alloc() fails, the function will immediately return 0,
…

                   failed?


…
> the event of failure in these two functions, it is still necessary
> to call the subsequent drm_edid_connector_update() function with
…

You may occasionally put more than 66 characters into text lines
of such a change description.


>                                    … To maintain the integrity of
> the operation, redundant error handling needs to be removed.

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc5#n145

Regards,
Markus