linux-kernel - RE: [PATCH] drm/exynos/vidi: Remove redundant error handling in vidi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000001db987f$479ece60$d6dc6b20$@samsung.com>
Date: Wed, 19 Mar 2025 12:30:36 +0900
From: 대인기/Tizen Platform Lab(SR)/삼성전자
	<inki.dae@...sung.com>
To: "'Wentao Liang'" <vulab@...as.ac.cn>, <jani.nikula@...ux.intel.com>,
	<sw0312.kim@...sung.com>, <kyungmin.park@...sung.com>, <airlied@...il.com>,
	<simona@...ll.ch>, <krzk@...nel.org>, <alim.akhtar@...sung.com>
Cc: <dri-devel@...ts.freedesktop.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-samsung-soc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drm/exynos/vidi: Remove redundant error handling in
 vidi_get_modes()

Hi,

> -----Original Message-----
> From: Wentao Liang <vulab@...as.ac.cn>
> Sent: Thursday, March 6, 2025 1:27 PM
> To: jani.nikula@...ux.intel.com; inki.dae@...sung.com;
> sw0312.kim@...sung.com; kyungmin.park@...sung.com; airlied@...il.com;
> simona@...ll.ch; krzk@...nel.org; alim.akhtar@...sung.com
> Cc: dri-devel@...ts.freedesktop.org; linux-arm-kernel@...ts.infradead.org;
> linux-samsung-soc@...r.kernel.org; linux-kernel@...r.kernel.org; Wentao
> Liang <vulab@...as.ac.cn>
> Subject: [PATCH] drm/exynos/vidi: Remove redundant error handling in
> vidi_get_modes()
> 
> In the vidi_get_modes() function, if either drm_edid_dup() or
> drm_edid_alloc() fails, the function will immediately return 0,
> indicating that no display modes can be retrieved. However, in
> the event of failure in these two functions, it is still necessary
> to call the subsequent drm_edid_connector_update() function with
> a NULL drm_edid as an argument. This ensures that operations such
> as connector settings are performed in its callee function,
> _drm_edid_connector_property_update. To maintain the integrity of
> the operation, redundant error handling needs to be removed.

You are right. Merged.

Thanks,
Inki Dae

> 
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_vidi.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> index fd388b1dbe68..a956cdb2f33a 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> @@ -312,9 +312,6 @@ static int vidi_get_modes(struct drm_connector
> *connector)
>  	else
>  		drm_edid = drm_edid_alloc(fake_edid_info,
> sizeof(fake_edid_info));
> 
> -	if (!drm_edid)
> -		return 0;
> -
>  	drm_edid_connector_update(connector, drm_edid);
> 
>  	count = drm_edid_connector_add_modes(connector);
> --
> 2.42.0.windows.2