linux-kernel - Re: [PATCH] page_io: return proper error codes for swap_read_folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKEwX=P+Oh+a0Pducc9v1EGsGVG4vi1RT4xywkvhnnA2hEpzCw@mail.gmail.com>
Date: Fri, 7 Mar 2025 09:03:33 -0800
From: Nhat Pham <nphamcs@...il.com>
To: Yosry Ahmed <yosry.ahmed@...ux.dev>
Cc: akpm@...ux-foundation.org, hannes@...xchg.org, chengming.zhou@...ux.dev, 
	linux-mm@...ck.org, kernel-team@...a.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] page_io: return proper error codes for swap_read_folio_zeromap()

On Thu, Mar 6, 2025 at 3:42 PM Yosry Ahmed <yosry.ahmed@...ux.dev> wrote:
>
> > + *
> > + *  -EINVAL: some of the subpages in the folio are zeromaped, but not all of
> > + *  them. This is an error because we don't currently support a large folio
> > + *  that is partially in the zeromap. The folio is unlocked, but NOT marked
> > + *  up-to-date, so that an IO error is emitted (e.g. do_swap_page() will
> > + *  sigbus).
>
> This is a bit repetitive. Maybe:
>
>  *  -EINVAL: The folio is partially in the zeromap, which is not
>  *  currently supported. The folio is unlocked, but NOT marked
>  *  up-to-date, so that an IO error is emitted (e.g. do_swap_page() will
>  *  sigbus).
>
>
>
> I would drop this whole comment now because it's mostly repeating what's
> now documneted above.
>
> With the comments fixed up:
>
> Reviewed-by: Yosry Ahmed <yosry.ahmed@...ux.dev>
>

Ah I like both suggestions :) Gimme one sec to send out a fixlet.

Thanks, Yosry!