linux-kernel - Re: [PATCH v7 12/49] x86/resctrl: Move rdt_find_domain() to be visible to arch and fs code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ebfd206a-1a48-4c3f-958a-7cf981dd3671@arm.com>
Date: Fri, 7 Mar 2025 19:35:34 +0000
From: James Morse <james.morse@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>,
 Babu Moger <Babu.Moger@....com>, shameerali.kolothum.thodi@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, lcherian@...vell.com,
 bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
 baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
 Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
 dfustini@...libre.com, amitsinght@...vell.com,
 David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Dave Martin <dave.martin@....com>, Koba Ko <kobak@...dia.com>,
 Shanker Donthineni <sdonthineni@...dia.com>, fenghuay@...dia.com
Subject: Re: [PATCH v7 12/49] x86/resctrl: Move rdt_find_domain() to be
 visible to arch and fs code

Hi Reinette,

On 07/03/2025 04:34, Reinette Chatre wrote:
> On 2/28/25 11:58 AM, James Morse wrote:
>> rdt_find_domain() finds a domain given a resource and a cache-id.
>> This is used by both the architecture code and the filesystem code.
>>
>> After the filesystem code moves to live in /fs/, this helper is either
>> duplicated by all architectures, or needs exposing by the filesystem code.
>>
>> Add the definition to the global header file. As its now globally visible,
> 
> "definition" -> "declaration"?

Ugh, I always get those the wrong way round.


>> and has only a handful of callers, swap the 'rdt' for 'resctrl'. Move
>> the function to live with its caller in ctrlmondata.c as the filesystem
>> code will not have anything corresponding to core.c.


> | Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>


Thanks!

James