linux-kernel - Re: [PATCH v7 19/49] x86/resctrl: Add resctrl_arch_is_evt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fe8b8be-d52b-4873-a4c5-a3b070190f2c@arm.com>
Date: Mon, 10 Mar 2025 12:26:46 +0000
From: James Morse <james.morse@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>,
 Babu Moger <Babu.Moger@....com>, shameerali.kolothum.thodi@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, lcherian@...vell.com,
 bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
 baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
 Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
 dfustini@...libre.com, amitsinght@...vell.com,
 David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Dave Martin <dave.martin@....com>, Koba Ko <kobak@...dia.com>,
 Shanker Donthineni <sdonthineni@...dia.com>, fenghuay@...dia.com,
 Shaopeng Tan <tan.shaopeng@...fujitsu.com>, Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH v7 19/49] x86/resctrl: Add
 resctrl_arch_is_evt_configurable() to abstract BMEC

Hi Reinette,

On 07/03/2025 04:37, Reinette Chatre wrote:
> On 2/28/25 11:58 AM, James Morse wrote:
>> When BMEC is supported the resctrl event can be configured in a number
>> of ways. This depends on architecture support. rdt_get_mon_l3_config()
>> modifies the struct mon_evt and calls mbm_config_rftype_init() to create
>> the files that allow the configuration.
>>
>> Splitting this into separate architecture and filesystem parts would
>> require the struct mon_evt and mbm_config_rftype_init() to be exposed.
> 
> Same comment as for v6 [1]:
> "Please replace all instances of mbm_config_rftype_init() with 
> resctrl_file_fflags_init()."

Ah - I didn't spot there was more than on in the commit message.
(and git-grep didn't bring it back either!)

Fixed.

>> Instead, add resctrl_arch_is_evt_configurable(), and use this from
>> resctrl_mon_resource_init() to initialise struct mon_evt and call
>> resctrl_file_fflags_init()
>> resctrl_arch_is_evt_configurable() calls rdt_cpu_has() so it doesn't
>> obviously benefit from being inlined. Putting it in core.c will allow
>> rdt_cpu_has() to eventually become static.
>>
>> Signed-off-by: James Morse <james.morse@....com>
>> Tested-by: Carl Worth <carl@...amperecomputing.com> # arm64
>> Tested-by: Shaopeng Tan <tan.shaopeng@...fujitsu.com>
>> Reviewed-by: Shaopeng Tan <tan.shaopeng@...fujitsu.com>
>> Reviewed-by: Tony Luck <tony.luck@...el.com>
>> ---
>> Changes since v6:
>>  * Fixed stale function name in the commit message.
> Fixes seem to have been lost.
> 
> With changelog fixed:
> | Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>


Thanks!

James