linux-kernel - Re: [PATCH v4 01/19] dt-bindings: mfd: mediatek: mt6397: Add accdet subnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0663e03e-e331-4a06-be95-ce8d9059ed6b@kernel.org>
Date: Fri, 7 Mar 2025 08:11:26 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nícolas F. R. A. Prado <nfraprado@...labora.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Sen Chu <sen.chu@...iatek.com>, Sean Wang <sean.wang@...iatek.com>,
 Macpaul Lin <macpaul.lin@...iatek.com>, Lee Jones <lee@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 kernel@...labora.com, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH v4 01/19] dt-bindings: mfd: mediatek: mt6397: Add accdet
 subnode

On 06/03/2025 13:19, Nícolas F. R. A. Prado wrote:
>>>    It is interfaced to host controller using SPI interface by a proprietary hardware
>>>    called PMIC wrapper or pwrap. MT6397/MT6323 PMIC is a child device of pwrap.
>>> @@ -224,6 +225,30 @@ properties:
>>>      description:
>>>        Pin controller
>>>  
>>> +  accdet:
>>> +    type: object
>>> +    additionalProperties: false
>>> +    description:
>>> +      The Accessory Detection module found on the PMIC allows detecting audio
>>> +      jack insertion and removal, as well as identifying the type of events
>>> +      connected to the jack.
>>> +
>>> +    properties:
>>> +      compatible:
>>> +        const: mediatek,mt6359-accdet
>>
>> You just removed the other file, no folding happened here. Drop the
>> accdet node and fold this into parent.
> 
> Sorry, I'm still not sure what you mean by folding here then. Right now the
> accdet is a subnode of the PMIC. If you want me to remove the accdet node, where

Yes

> would its compatible and property go?

compatible: nowhere, because it is close to redundancy.

property: to the parent pmic node.

    pmic {
        compatible = "mediatek,mt6359";
        interrupt-controller;
        #interrupt-cells = <2>;

        mediatek,hp-eint-high;
    };

Best regards,
Krzysztof