linux-kernel - Re: [PATCH 1/2] tty: serial: fsl_lpuart: Use u32 for register variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52c99f0a-670c-4e76-a30d-cdb9cb0e83e7@kernel.org>
Date: Fri, 7 Mar 2025 08:25:31 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: Sherry Sun <sherry.sun@....com>, gregkh@...uxfoundation.org
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, shenwei.wang@....com
Subject: Re: [PATCH 1/2] tty: serial: fsl_lpuart: Use u32 for register
 variables

On 07. 03. 25, 3:25, Sherry Sun wrote:
> Use u32 rather than unsigned long for register variables for clarity and
> consistency.
> 
> Signed-off-by: Sherry Sun <sherry.sun@....com>
> ---
>   drivers/tty/serial/fsl_lpuart.c | 54 ++++++++++++++++-----------------
>   1 file changed, 27 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
> index 4dc2f3e2b8e0..888d744494d6 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -450,7 +450,7 @@ static void lpuart_stop_tx(struct uart_port *port)
>   
>   static void lpuart32_stop_tx(struct uart_port *port)
>   {
> -	unsigned long temp;
> +	u32 temp;

This patch is fine per se. But could you also rename these temps to 
something sane? (In a separate patch.) Like ctrl in this case.

thanks,
-- 
js
suse labs