linux-kernel - Re: [PATCH v2 3/8] sched/deadline: Generalize unique visiting of root domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8q0hQAHLlYxuHBY@jlelli-thinkpadt14gen4.remote.csb>
Date: Fri, 7 Mar 2025 08:55:33 +0000
From: Juri Lelli <juri.lelli@...hat.com>
To: Shrikanth Hegde <sshegde@...ux.ibm.com>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Waiman Long <longman@...hat.com>, Tejun Heo <tj@...nel.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Michal Koutný <mkoutny@...e.com>,
	Qais Yousef <qyousef@...alina.io>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Swapnil Sapkal <swapnil.sapkal@....com>,
	Phil Auld <pauld@...hat.com>, luca.abeni@...tannapisa.it,
	tommaso.cucinotta@...tannapisa.it,
	Jon Hunter <jonathanh@...dia.com>, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/8] sched/deadline: Generalize unique visiting of
 root domains

On 07/03/25 11:06, Shrikanth Hegde wrote:
> 
> 
> On 3/6/25 19:40, Juri Lelli wrote:
> > Bandwidth checks and updates that work on root domains currently employ
> > a cookie mechanism for efficiency. This mechanism is very much tied to
> > when root domains are first created and initialized.
> > 
> > Generalize the cookie mechanism so that it can be used also later at
> > runtime while updating root domains. Also, additionally guard it with
> > sched_domains_mutex, since domains need to be stable while updating them
> > (and it will be required for further dynamic changes).
> > 
> > Reported-by: Jon Hunter <jonathanh@...dia.com>
> > Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for hotplug")
> > Signed-off-by: Juri Lelli <juri.lelli@...hat.com>

...

> > @@ -3192,7 +3195,7 @@ int sched_dl_global_validate(void)
> >   	for_each_possible_cpu(cpu) {
> 
> This has been changed in 14672f059d83f591afb2ee1fff56858efe055e5a to online
> CPUs. So patch didn't apply cleanly to me.
> 

I based the set on Linus' tree (base commit in the cover letter) as it
is modifying both sched and cgroup bits. Your fix hasn't yet be merged
into Linus' I believe.

Thanks,
Juri