linux-kernel - Re: [PATCH] crypto: ccp: Fix uAPI definitions of PSP errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAH4kHaK3Z-_aYizZM0Kvmsjvs_RT88tKG5aefm2_9GTUsU4bg@mail.gmail.com>
Date: Fri, 7 Mar 2025 21:40:52 -0800
From: Dionna Amalie Glaze <dionnaglaze@...gle.com>
To: Alexey Kardashevskiy <aik@....com>
Cc: linux-crypto@...r.kernel.org, linux-coco@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, Ashish Kalra <ashish.kalra@....com>, 
	Tom Lendacky <thomas.lendacky@....com>, "Borislav Petkov (AMD)" <bp@...en8.de>, 
	Herbert Xu <herbert@...dor.apana.org.au>, stable@...r.kernel.org
Subject: Re: [PATCH] crypto: ccp: Fix uAPI definitions of PSP errors

On Fri, Mar 7, 2025 at 5:10 PM Alexey Kardashevskiy <aik@....com> wrote:
>
> Additions to the error enum after explicit 0x27 setting for
> SEV_RET_INVALID_KEY leads to incorrect value assignments.
>
> Use explicit values to match the manufacturer specifications more
> clearly.
>
> Fixes: 3a45dc2b419e ("crypto: ccp: Define the SEV-SNP commands")
> CC: stable@...r.kernel.org
> Signed-off-by: Dionna Glaze <dionnaglaze@...gle.com>
> Reviewed-by: Tom Lendacky <thomas.lendacky@....com>
> Signed-off-by: Alexey Kardashevskiy <aik@....com>
> ---
>
> Reposting as requested in
> https://lore.kernel.org/r/Z7f2S3MigLEY80P2@gondor.apana.org.au
>
> I wrote it in the first place but since then it travelled a lot,
> feel free to correct the chain of SOBs and RB :)

It's all good. Thanks for seeing this through to the end.


-- 
-Dionna Glaze, PhD, CISSP, CCSP (she/her)