linux-kernel - Re: [PATCH] crypto: ccp: Fix uAPI definitions of PSP errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250308133308.GCZ8xHFOX4JKRG1Mpk@fat_crate.local>
Date: Sat, 8 Mar 2025 14:33:08 +0100
From: Borislav Petkov <bp@...en8.de>
To: Dionna Amalie Glaze <dionnaglaze@...gle.com>,
	Alexey Kardashevskiy <aik@....com>
Cc: linux-crypto@...r.kernel.org, linux-coco@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Ashish Kalra <ashish.kalra@....com>,
	Tom Lendacky <thomas.lendacky@....com>,
	Herbert Xu <herbert@...dor.apana.org.au>, stable@...r.kernel.org
Subject: Re: [PATCH] crypto: ccp: Fix uAPI definitions of PSP errors

On Fri, Mar 07, 2025 at 09:40:52PM -0800, Dionna Amalie Glaze wrote:
> On Fri, Mar 7, 2025 at 5:10 PM Alexey Kardashevskiy <aik@....com> wrote:
> >
> > Additions to the error enum after explicit 0x27 setting for
> > SEV_RET_INVALID_KEY leads to incorrect value assignments.
> >
> > Use explicit values to match the manufacturer specifications more
> > clearly.
> >
> > Fixes: 3a45dc2b419e ("crypto: ccp: Define the SEV-SNP commands")
> > CC: stable@...r.kernel.org
> > Signed-off-by: Dionna Glaze <dionnaglaze@...gle.com>
> > Reviewed-by: Tom Lendacky <thomas.lendacky@....com>
> > Signed-off-by: Alexey Kardashevskiy <aik@....com>
> > ---
> >
> > Reposting as requested in
> > https://lore.kernel.org/r/Z7f2S3MigLEY80P2@gondor.apana.org.au
> >
> > I wrote it in the first place but since then it travelled a lot,
> > feel free to correct the chain of SOBs and RB :)
> 
> It's all good. Thanks for seeing this through to the end.

It should be corrected because the current SOB chain says that Dionna is the
author but From is yours, making you the author when it gets applied.

All is documented here and in the following sections:

https://kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette