linux-kernel - Re: [PATCH] fbdev: fsl-diu-fb: add missing device_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91f20115-5579-4915-8dcd-b6b332ec73ee@gmx.de>
Date: Sun, 9 Mar 2025 03:28:17 +0100
From: Helge Deller <deller@....de>
To: oushixiong1025@....com, Timur Tabi <timur@...nel.org>
Cc: linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, Shixiong Ou <oushixiong@...inos.cn>
Subject: Re: [PATCH] fbdev: fsl-diu-fb: add missing device_remove_file()

On 2/8/25 11:23, oushixiong1025@....com wrote:
> From: Shixiong Ou <oushixiong@...inos.cn>
>
> Call device_remove_file() when driver remove.
>
> Signed-off-by: Shixiong Ou <oushixiong@...inos.cn>
> ---
>   drivers/video/fbdev/fsl-diu-fb.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
> index 5ac8201c3533..8c91af9a9156 100644
> --- a/drivers/video/fbdev/fsl-diu-fb.c
> +++ b/drivers/video/fbdev/fsl-diu-fb.c
> @@ -1807,6 +1807,7 @@ static int fsl_diu_probe(struct platform_device *pdev)
>   	if (ret) {
>   		dev_err(&pdev->dev, "could not create sysfs file %s\n",
>   			data->dev_attr.attr.name);
> +		goto error;

this seems to miss calling free_irq() then at least...

Helge