linux-kernel - Re: [v2] PCI: cadence: Add configuration space capability search API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250309023839.2cakdpmsbzn6pm7g@uda0492258>
Date: Sun, 9 Mar 2025 08:08:39 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Hans Zhang <18255117159@....com>
CC: <lpieralisi@...nel.org>, <kw@...ux.com>,
        <manivannan.sadhasivam@...aro.org>, <robh@...nel.org>,
        <bhelgaas@...gle.com>, <bwawrzyn@...co.com>, <s-vadapalli@...com>,
        <thomas.richard@...tlin.com>,
        <wojciech.jasko-EXT@...tinental-corporation.com>,
        <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [v2] PCI: cadence: Add configuration space capability search API

On Sat, Mar 08, 2025 at 09:39:03PM +0800, Hans Zhang wrote:
> Add configuration space capability search API using struct cdns_pcie*
> pointer.
> 
> The offset address of capability or extended capability designed by
> different SOC design companies may not be the same. Therefore, a flexible
> public API is required to find the offset address of a capability or
> extended capability in the configuration space.
> 
> Signed-off-by: Hans Zhang <18255117159@....com>
> ---
> Changes since v1:
> https://lore.kernel.org/linux-pci/20250123070935.1810110-1-18255117159@163.com
> 
> - Added calling the new API in PCI-Cadence ep.c.
> - Add a commit message reason for adding the API.

In reply to your v1 patch, you have mentioned the following:
"Our controller driver currently has no plans for upstream and needs to
wait for notification from the boss."
at:
https://lore.kernel.org/linux-pci/fcfd4827-4d9e-4bcd-b1d0-8f9e349a6be7@163.com/

Since you have posted this patch, does it mean that you will be
upstreaming your driver as well? If not, we still end up in the same
situation as earlier where the Upstream Linux has APIs to support a
Downstream driver.

Bjorn indicated the above already at:
https://lore.kernel.org/linux-pci/20250123170831.GA1226684@bhelgaas/
and you did agree to do so. But this patch has no reference to the
upstream driver series which shall be making use of the APIs in this
patch.

Regards,
Siddharth.