linux-kernel - Re: [PATCH V9 1/2] rust: module: change author to an array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=LwF0_ozgWLMucQmDg7o_vz8XJWHqSfWwE7-amhjCsvw@mail.gmail.com>
Date: Sun, 9 Mar 2025 23:42:16 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
Cc: a.hindborg@...nel.org, alex.gaynor@...il.com, aliceryhl@...gle.com, 
	apw@...onical.com, arnd@...db.de, aswinunni01@...il.com, axboe@...nel.dk, 
	benno.lossin@...ton.me, bhelgaas@...gle.com, bjorn3_gh@...tonmail.com, 
	boqun.feng@...il.com, dakr@...nel.org, dwaipayanray1@...il.com, 
	ethan.twardy@...il.com, fujita.tomonori@...il.com, gary@...yguo.net, 
	gregkh@...uxfoundation.org, joe@...ches.com, lukas.bulwahn@...il.com, 
	ojeda@...nel.org, pbonzini@...hat.com, tmgross@...ch.edu, 
	walmeida@...rosoft.com, charmitro@...teo.net, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V9 1/2] rust: module: change author to an array

On Sun, Mar 9, 2025 at 6:57 PM Guilherme Giacomo Simoes
<trintaeoitogc@...il.com> wrote:
>
> -    if let Some(author) = info.author {
> -        modinfo.emit("author", &author);
> +    if let Some(authors) = info.authors {
> +        for author in authors {
> +            modinfo.emit("authors", &author);
> +        }

I guess nobody actually tested this... :)

The `modinfo` key should not change -- we want to still use `author`,
not `authors`, i.e. before this change:

    $ modinfo -k . -a samples/rust/rust_print.ko
    Rust for Linux Contributors

But after:

    $ modinfo -k . -a samples/rust/rust_print.ko

Anyway, I am considering applying this one with that fixed on my side,
but also, to simplify conflict handling, it may be best to keep the
old `author` field anyway working for a cycle or two (undocumented).

Guilherme: if I end up applying this, you can still send the second
patch on its own, based on top of `rust-next`, i.e. just the
`checkpatch.pl` one.

Cheers,
Miguel