linux-kernel - Re: [PATCH V9 1/2] rust: module: change author to an array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kHuQxP5J--Y5vtT9d2mJ=0k-xVW+irJzhibAG2BDgSzw@mail.gmail.com>
Date: Mon, 10 Mar 2025 01:45:49 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
Cc: a.hindborg@...nel.org, alex.gaynor@...il.com, aliceryhl@...gle.com, 
	apw@...onical.com, arnd@...db.de, aswinunni01@...il.com, axboe@...nel.dk, 
	benno.lossin@...ton.me, bhelgaas@...gle.com, bjorn3_gh@...tonmail.com, 
	boqun.feng@...il.com, dakr@...nel.org, dwaipayanray1@...il.com, 
	ethan.twardy@...il.com, fujita.tomonori@...il.com, gary@...yguo.net, 
	gregkh@...uxfoundation.org, joe@...ches.com, lukas.bulwahn@...il.com, 
	ojeda@...nel.org, pbonzini@...hat.com, tmgross@...ch.edu, 
	walmeida@...rosoft.com, charmitro@...teo.net, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V9 1/2] rust: module: change author to an array

On Sun, Mar 9, 2025 at 6:57 PM Guilherme Giacomo Simoes
<trintaeoitogc@...il.com> wrote:
>
> In the module! macro, the author field is currently of type String.
> Since modules can have multiple authors, this limitation prevents
> specifying more than one.
> Change the author field to Option<Vec<String>> to allow creating modules
> with multiple authors. Additionally, rename the field from author to
> authors to make it explicit that it can refer to multiple authors.  In
> modules that use the author field, update its value to an array of
> strings, and also rename it from author to authors.
>
> Suggested-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
> Link: https://github.com/Rust-for-Linux/linux/issues/244
> Reviewed-by: Charalampos Mitrodimas <charmitro@...teo.net>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> Reviewed-by: Andreas Hindborg <a.hindborg@...nel.org>
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>

Applied to `rust-next` -- thanks everyone!

    [ The `modinfo` key needs to still be `author`; otherwise, tooling
      may not work properly, e.g.:

          $ modinfo -k . -a samples/rust/rust_print.ko
          Rust for Linux Contributors

      I have also kept the original `author` field (undocumented), so
      that we can drop it more easily in a kernel cycle or two.

        - Miguel ]

    [ Fixed `modinfo` key. Kept `author` field. Reworded message
      accordingly. Updated my email. - Miguel ]

I didn't drop the Reviewed-by's -- the fix I did is a single letter
change, but conceptually keeping the `author` field is a bigger change
-- if someone disagrees, please just let me know and I will drop your
tag.

Thanks!

Cheers,
Miguel