linux-kernel - Re: [PATCH] platform/x86/amd: pmf: Fix missing hidden options for Smart PC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50adcc9d-241d-19b6-7b03-2e91ef7d017b@linux.intel.com>
Date: Mon, 10 Mar 2025 19:19:25 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Mario Limonciello <superm1@...nel.org>
cc: Shyam Sundar S K <Shyam-sundar.S-k@....com>, 
    "Rafael J . Wysocki" <rafael@...nel.org>, 
    Hans de Goede <hdegoede@...hat.com>, "Luke D . Jones" <luke@...nes.dev>, 
    Mark Pearson <mpearson-lenovo@...ebb.ca>, 
    "open list:AMD PMF DRIVER" <platform-driver-x86@...r.kernel.org>, 
    open list <linux-kernel@...r.kernel.org>, 
    "open list:ACPI" <linux-acpi@...r.kernel.org>, 
    "Derek J . Clark" <derekjohn.clark@...il.com>, 
    Antheas Kapenekakis <lkml@...heas.dev>, me@...egospodneti.ch, 
    Denis Benato <benato.denis96@...il.com>, 
    Mario Limonciello <mario.limonciello@....com>, 
    Yijun Shen <Yijun.Shen@...l.com>
Subject: Re: [PATCH] platform/x86/amd: pmf: Fix missing hidden options for
 Smart PC

On Wed, 5 Mar 2025, Mario Limonciello wrote:

> From: Mario Limonciello <mario.limonciello@....com>
> 
> amd_pmf_get_slider_info() checks the current profile to report correct
> value to the TA inputs.  If hidden options are in use then the wrong
> values will be reported to TA.
> 
> Add the two compat options PLATFORM_PROFILE_BALANCED_PERFORMANCE and
> PLATFORM_PROFILE_QUIET for this use.
> 
> Reported-by: Yijun Shen <Yijun.Shen@...l.com>
> Fixes: 9a43102daf64d ("platform/x86/amd: pmf: Add balanced-performance to hidden choices")
> Fixes: 44e94fece5170 ("platform/x86/amd: pmf: Add 'quiet' to hidden choices")
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
>  drivers/platform/x86/amd/pmf/spc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/pmf/spc.c b/drivers/platform/x86/amd/pmf/spc.c
> index f34f3130c3307..1d90f9382024b 100644
> --- a/drivers/platform/x86/amd/pmf/spc.c
> +++ b/drivers/platform/x86/amd/pmf/spc.c
> @@ -219,12 +219,14 @@ static int amd_pmf_get_slider_info(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>  
>  	switch (dev->current_profile) {
>  	case PLATFORM_PROFILE_PERFORMANCE:
> +	case PLATFORM_PROFILE_BALANCED_PERFORMANCE:
>  		val = TA_BEST_PERFORMANCE;
>  		break;
>  	case PLATFORM_PROFILE_BALANCED:
>  		val = TA_BETTER_PERFORMANCE;
>  		break;
>  	case PLATFORM_PROFILE_LOW_POWER:
> +	case PLATFORM_PROFILE_QUIET:
>  		val = TA_BEST_BATTERY;
>  		break;
>  	default:

Hi Mario,

Just for me to be sure what I'm supposed to do with all these patches 
related to this platform profile legacy handling... :-)

So this fix is necessary in addition to the 3 patches that got already 
merged through Rafaels tree?

What about this patch from Luke:

https://patchwork.kernel.org/project/platform-driver-x86/patch/20250224223551.16918-1-luke@ljones.dev/

Is that also needed?

Thanks in advance.

-- 
 i.