linux-kernel - Re: [PATCH] module: Remove unnecessary size argument when calling strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d21bf87-37c6-406f-8705-82968ba0e8df@suse.com>
Date: Mon, 10 Mar 2025 12:08:29 +0100
From: Petr Pavlu <petr.pavlu@...e.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Luis Chamberlain <mcgrof@...nel.org>,
 Sami Tolvanen <samitolvanen@...gle.com>, Daniel Gomez
 <da.gomez@...sung.com>, linux-modules@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] module: Remove unnecessary size argument when calling
 strscpy()

On 3/8/25 20:46, Thorsten Blum wrote:
> The size parameter is optional and strscpy() automatically determines
> the length of the destination buffer using sizeof() if the argument is
> omitted. This makes the explicit sizeof() unnecessary. Remove it to
> shorten and simplify the code.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Looks good to me. I've queued it on modules-next.

-- 
Thanks,
Petr