linux-kernel - Re: [tip: x86/boot] x86/bootflag: Replace open-coded parity calculation with parity8()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9BNGeZBh/6gJfHT@visitorckw-System-Product-Name>
Date: Tue, 11 Mar 2025 22:47:53 +0800
From: Kuan-Wei Chiu <visitorckw@...il.com>
To: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>
Cc: linux-tip-commits@...r.kernel.org, Yu-Chun Lin <eleanor15x@...il.com>,
	Uros Bizjak <ubizjak@...il.com>, Ingo Molnar <mingo@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [tip: x86/boot] x86/bootflag: Replace open-coded parity
 calculation with parity8()

Hi Ingo,

On Thu, Feb 27, 2025 at 01:15:13PM -0000, tip-bot2 for Kuan-Wei Chiu wrote:
> The following commit has been merged into the x86/boot branch of tip:
> 
> Commit-ID:     9c94c14ca39577b6324c667d8450ffa19fc1e5c4
> Gitweb:        https://git.kernel.org/tip/9c94c14ca39577b6324c667d8450ffa19fc1e5c4
> Author:        Kuan-Wei Chiu <visitorckw@...il.com>
> AuthorDate:    Thu, 27 Feb 2025 13:55:45 +01:00
> Committer:     Ingo Molnar <mingo@...nel.org>
> CommitterDate: Thu, 27 Feb 2025 14:00:30 +01:00
> 
> x86/bootflag: Replace open-coded parity calculation with parity8()
> 
> Refactor parity calculations to use the standard parity8() helper. This
> change eliminates redundant implementations and improves code
> efficiency.
> 
> [ ubizjak: Updated the patch to apply to the latest x86 tree. ]
> 
> Co-developed-by: Yu-Chun Lin <eleanor15x@...il.com>
> Signed-off-by: Yu-Chun Lin <eleanor15x@...il.com>
> Signed-off-by: Kuan-Wei Chiu <visitorckw@...il.com>
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Link: https://lore.kernel.org/r/20250227125616.2253774-1-ubizjak@gmail.com

Thanks for accepting this patch.

Based on the previous email discussion, I plan to rename parity8() to
parity_odd() in the next version of the parity patch series (though I'm
not too confident it will be accepted...). If I base the series on the
current linux-next tree, it might cause conflicts when other
maintainers apply it to their own trees. On the other hand, if I base
it on Linus's tree, it would conflict with the x86 tree.

I'm not sure which tree I should base the next version on. Since this
series touches multiple subsystems, the situation is a bit tricky.

Regards,
Kuan-Wei