linux-kernel - Re: [PATCH] x86/stackprotector: fix build failure with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMzpN2hb7uD6Z410YFPYiGQvsV6-9b8iMXXCtfJYJ7ATwO-L5g@mail.gmail.com>
Date: Tue, 11 Mar 2025 17:27:29 -0400
From: Brian Gerst <brgerst@...il.com>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Borislav Petkov <bp@...en8.de>, Ard Biesheuvel <ardb@...nel.org>, linux-kernel@...r.kernel.org, 
	x86@...nel.org, Ingo Molnar <mingo@...nel.org>, "H . Peter Anvin" <hpa@...or.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Uros Bizjak <ubizjak@...il.com>, stable@...r.kernel.org, 
	Fangrui Song <i@...kray.me>, Nathan Chancellor <nathan@...nel.org>, Andy Lutomirski <luto@...nel.org>
Subject: Re: [PATCH] x86/stackprotector: fix build failure with CONFIG_STACKPROTECTOR=n

On Tue, Mar 11, 2025 at 3:24 PM Oleg Nesterov <oleg@...hat.com> wrote:
>
> On 03/11, Borislav Petkov wrote:
> >
> > On Tue, Mar 11, 2025 at 07:10:57PM +0100, Oleg Nesterov wrote:
> > > See the "older binutils?" above ;)
> > >
> > > my toolchain is quite old,
> > >
> > >     $ ld -v
> > >     GNU ld version 2.25-17.fc23
> > >
> > > but according to Documentation/process/changes.rst
> > >
> > >     binutils               2.25             ld -v
> > >
> > > it should be still supported.
> >
> > So your issue happens because of older binutils? Any other ingredient?
>
> Yes, I think so.
>
> > I'd like for the commit message to contain *exactly* what we're fixing here so
> > that anyone who reads this, can know whether this fix is needed on her/his
> > kernel or not...
>
> OK. I'll update the subject/changelog to explain that this is only
> needed for the older binutils and send V2.

With it conditional on CONFIG_STACKPROTECTOR, you can also drop PROVIDES().


Brian Gerst