linux-kernel - Re: [net-next PATCH v3 2/2] octeontx2-af: fix compiler warnings flagged by Sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3bc07f4f-73b4-4d34-98cb-79e84d9f1493@lunn.ch>
Date: Tue, 11 Mar 2025 22:32:12 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Sai Krishna <saikrishnag@...vell.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, sgoutham@...vell.com,
	gakula@...vell.com, lcherian@...vell.com, jerinj@...vell.com,
	hkelam@...vell.com, sbhatta@...vell.com, andrew+netdev@...n.ch,
	bbhushan2@...vell.com, nathan@...nel.org, ndesaulniers@...gle.com,
	morbo@...gle.com, justinstitt@...gle.com, llvm@...ts.linux.dev,
	horms@...nel.org
Subject: Re: [net-next PATCH v3 2/2] octeontx2-af: fix compiler warnings
 flagged by Sparse

On Tue, Mar 11, 2025 at 11:56:31PM +0530, Sai Krishna wrote:
> Sparse flagged a number of warnings while typecasting iomem
> type to required data type.
 
> For example, fwdata is just a shared memory data structure used
> between firmware and kernel, thus remapping and typecasting
> to required data type may not cause issue.

This is generally wrong. __iomem is there for a reason. If you are
removing it, it suggests what you do next with the pointer is wrong.

    Andrew

---
pw-bot: cr