linux-kernel - Re: [RFC PATCH 1/3] thermal/cpuplog_cooling: Add CPU hotplug cooling driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWV7CNBJbPKpymBvvQTbHcpSYFA7DfbOr27CRwwGxh18A@mail.gmail.com>
Date: Tue, 11 Mar 2025 09:28:01 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: John Madieu <john.madieu.xa@...renesas.com>
Cc: niklas.soderlund+renesas@...natech.se, conor+dt@...nel.org, 
	krzk+dt@...nel.org, robh@...nel.org, rafael@...nel.org, 
	daniel.lezcano@...aro.org, magnus.damm@...il.com, 
	claudiu.beznea.uj@...renesas.com, devicetree@...r.kernel.org, 
	john.madieu@...il.com, rui.zhang@...el.com, linux-kernel@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, biju.das.jz@...renesas.com, 
	linux-pm@...r.kernel.org
Subject: Re: [RFC PATCH 1/3] thermal/cpuplog_cooling: Add CPU hotplug cooling driver

Hi John,

On Sun, 9 Mar 2025 at 13:14, John Madieu <john.madieu.xa@...renesas.com> wrote:
> Add thermal cooling mechanism that dynamically manages CPU online/offline
> states to prevent overheating. It registers  per-CPU cooling devices that can
> take CPUs offline when thermal thresholds are excee and that integrates with
> the Linux thermal framework as a cooling devices.
>
> Signed-off-by: John Madieu <john.madieu.xa@...renesas.com>

Thanks for your patch!

> --- /dev/null
> +++ b/drivers/thermal/cpuplug_cooling.c

> +static int register_cpu_hotplug_cooling(struct device_node *cpu_node,
> +                                       int cpu_id)
> +{

> +       hotplug_cdev = kzalloc(sizeof(*hotplug_cdev), GFP_KERNEL);
> +       if (!hotplug_cdev) {
> +               pr_err("Failed to allocate memory for cooling device\n");

scripts/checkpatch.pl:

WARNING: Possible unnecessary 'out of memory' message

and checkpatch is right, as the memory core already takes care of
printing a message.

> +               return -ENOMEM;
> +       }

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds