linux-kernel - Re: [PATCH v5] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47785d3f-3560-4832-b88a-031a80d1fd28@linux.alibaba.com>
Date: Tue, 11 Mar 2025 10:06:56 +0800
From: Shuai Xue <xueshuai@...ux.alibaba.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: lukas@...ner.de, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-edac@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 helgaas@...nel.org, bhelgaas@...gle.com, tony.luck@...el.com, bp@...en8.de,
 mhiramat@...nel.org, mathieu.desnoyers@...icios.com, oleg@...hat.com,
 naveen@...nel.org, davem@...emloft.net, anil.s.keshavamurthy@...el.com,
 mark.rutland@....com, peterz@...radead.org, tianruidong@...ux.alibaba.com
Subject: Re: [PATCH v5] PCI: hotplug: Add a generic RAS tracepoint for hotplug
 event



在 2025/3/10 22:50, Steven Rostedt 写道:
> On Mon, 10 Mar 2025 11:59:55 +0800
> Shuai Xue <xueshuai@...ux.alibaba.com> wrote:
> 
>> Hi, Steve,
>>
>> If I move PCI_HOTPLUG_EVENT into one place, `include/upai/linux/pci.h`,
>> I need to include:
>>
>>       #include <linux/tracepoint.h>
>>
>> Then, kernel build fails with CONFIG_UAPI_HEADER_TEST=y:
> 
> Just move the enum definitions, not the entire event file.
> 
> That is, have one place has the PCI_HOTPLUG_EVENT macro, and have both the
> uapi header as well as the tracepoint header include that header.
> 
> I guess I need to see the entire change.
> 

Hi, Steven,

IMHO, the problem is that the PCI_HOTPLUG_EVENT macro needs to include
"linux/tracepoint.h" but it is not allowed in userspace.

The entire change in v6 build fails with CONFIG_UAPI_HEADER_TEST=y:

   https://lore.kernel.org/lkml/202501190108.tRReJA1Z-lkp@intel.com/T/#mae507b91b8b80c386dfa9e63fbbdd45826c2e003

(sorry, I did not see the problem because my local .config do not set
CONFIG_UAPI_HEADER_TEST)

Thanks
Shuai