linux-kernel - Re: (subset) [PATCH v3 00/16] Converge on using secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250310190803.aaf868760781c9ae3fbe6df1@linux-foundation.org>
Date: Mon, 10 Mar 2025 19:08:03 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: Yaron Avizrat <yaron.avizrat@...el.com>, Oded Gabbay
 <ogabbay@...nel.org>, Julia Lawall <Julia.Lawall@...ia.fr>, Nicolas Palix
 <nicolas.palix@...g.fr>, James Smart <james.smart@...adcom.com>, Dick
 Kennedy <dick.kennedy@...adcom.com>, "James E.J. Bottomley"
 <James.Bottomley@...senPartnership.com>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Chris Mason <clm@...com>, Josef Bacik
 <josef@...icpanda.com>, David Sterba <dsterba@...e.com>, Ilya Dryomov
 <idryomov@...il.com>, Dongsheng Yang <dongsheng.yang@...ystack.cn>, Jens
 Axboe <axboe@...nel.dk>, Xiubo Li <xiubli@...hat.com>, Damien Le Moal
 <dlemoal@...nel.org>, Niklas Cassel <cassel@...nel.org>, Carlos Maiolino
 <cem@...nel.org>, "Darrick J. Wong" <djwong@...nel.org>, Sebastian Reichel
 <sre@...nel.org>, Keith Busch <kbusch@...nel.org>, Christoph Hellwig
 <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, Frank Li
 <Frank.Li@....com>, Mark Brown <broonie@...nel.org>, Shawn Guo
 <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix
 Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>, Hans de Goede
 <hdegoede@...hat.com>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, Henrique de Moraes Holschuh
 <hmh@....eng.br>, Selvin Xavier <selvin.xavier@...adcom.com>, Kalesh AP
 <kalesh-anakkur.purayil@...adcom.com>, Jason Gunthorpe <jgg@...pe.ca>, Leon
 Romanovsky <leon@...nel.org>, Easwar Hariharan
 <eahariha@...ux.microsoft.com>, cocci@...ia.fr,
 linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-sound@...r.kernel.org,
 linux-btrfs@...r.kernel.org, ceph-devel@...r.kernel.org,
 linux-block@...r.kernel.org, linux-ide@...r.kernel.org,
 linux-xfs@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-nvme@...ts.infradead.org, linux-spi@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 platform-driver-x86@...r.kernel.org, ibm-acpi-devel@...ts.sourceforge.net,
 linux-rdma@...r.kernel.org, Takashi Iwai <tiwai@...e.de>, Carlos Maiolino
 <cmaiolino@...hat.com>
Subject: Re: (subset) [PATCH v3 00/16] Converge on using secs_to_jiffies()
 part two

On Mon, 10 Mar 2025 21:19:03 -0400 "Martin K. Petersen" <martin.petersen@...cle.com> wrote:

> On Tue, 25 Feb 2025 20:17:14 +0000, Easwar Hariharan wrote:
> 
> > This is the second series (part 1*) that converts users of msecs_to_jiffies() that
> > either use the multiply pattern of either of:
> > - msecs_to_jiffies(N*1000) or
> > - msecs_to_jiffies(N*MSEC_PER_SEC)
> > 
> > where N is a constant or an expression, to avoid the multiplication.
> > 
> > [...]
> 
> Applied to 6.15/scsi-queue, thanks!
> 
> [02/16] scsi: lpfc: convert timeouts to secs_to_jiffies()
>         https://git.kernel.org/mkp/scsi/c/a131f20804d6

Really, an acked-by would have been much easier all around, but whatever.

Did you get my fix?

From: Andrew Morton <akpm@...ux-foundation.org>
Subject: scsi-lpfc-convert-timeouts-to-secs_to_jiffies-fix
Date: Tue Feb 25 07:32:03 PM PST 2025

fix build

Cc: Easwar Hariharan <eahariha@...ux.microsoft.com>
Cc: James Bottomley <james.bottomley@...senPartnership.com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 drivers/scsi/lpfc/lpfc_sli.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/scsi/lpfc/lpfc_sli.c~scsi-lpfc-convert-timeouts-to-secs_to_jiffies-fix
+++ a/drivers/scsi/lpfc/lpfc_sli.c
@@ -3954,7 +3954,7 @@ void lpfc_poll_eratt(struct timer_list *
 	else
 		/* Restart the timer for next eratt poll */
 		mod_timer(&phba->eratt_poll,
-			  jiffies + secs_to_jiffies(phba->eratt_poll_interval);
+			  jiffies + secs_to_jiffies(phba->eratt_poll_interval));
 	return;
 }

_