linux-kernel - Re: [PATCH v2] USB: serial: ftdi_sio: add support for Altera USB Blaster 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9AtkeGJqFTGMyTB@hovoldconsulting.com>
Date: Tue, 11 Mar 2025 13:33:21 +0100
From: Johan Hovold <johan@...nel.org>
To: "Ng, Boon Khai" <boon.khai.ng@...el.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb <linux-usb@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Boon Khai Ng <boon.khai.ng@...era.com>,
	Tien Sung Ang <tien.sung.ang@...era.com>
Subject: Re: [PATCH v2] USB: serial: ftdi_sio: add support for Altera USB
 Blaster 3

On Tue, Mar 11, 2025 at 10:34:33AM +0000, Ng, Boon Khai wrote:

> > These configurations were not mentioned in the commit message. Are they
> > also used for embedded designs?
> 
> Looks like the table I provided in the commit message is mismatched with 
> the one that I intended to check in for upstream.
> 
> Let me correct this, the one that I published for upstream was the actual tested
> code, whereby we want the UART to be exposed to the ftdi_sio driver.
> 
> Below is the updated table, 
> 1) PID 0x6022, FT2232, 1 JTAG port(Port A) + Port B as UART
> 2) PID 0x6025, FT4232, 1 JTAG port(Port A) + Port C as UART
> 3) PID 0x6026, FT4232, 1 JTAG port(Port A) + Port C, D as UART
> 4) PID 0x6029, FT4232, 1 JTAG port(Port B) + Port C as UART
> 5) PID 0x602a, FT4232, 1 JTAG port(Port B) + Port C, D as UART
> 6) PID 0x602c, FT4232, 1 JTAG port(Port A) + Port B as UART
> 7) PID 0x602d, FT4232, 1 JTAG port(Port A) + Port B, C as UART
> 8) PID 0x602e, FT4232, 1 JTAG port(Port A) + Port B, C, D as UART
> 
> Since we need UART to be exposed to the ftdi_sio driver and the cable USB Blaster
> does not support UART, will reword that on the commit message to remove the 
> cable USB Blaster and left only the on-board USB Blaster.

It may still be good to mention the cable in some way as it's not
obvious that there are both standalone (cable) and embedded variants.
 
> Will submit a v3 on this, with the reworded commit message plus the change log.

Sounds good. I'll wait for the v3.

Johan