linux-kernel - Re: [PATCH] nvmet-fc: Remove unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38766aaa-2080-4774-b215-f21d6fab35d5@nvidia.com>
Date: Wed, 12 Mar 2025 17:43:04 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: WangYuli <wangyuli@...ontech.com>, "james.smart@...adcom.com"
	<james.smart@...adcom.com>, "hch@....de" <hch@....de>, "sagi@...mberg.me"
	<sagi@...mberg.me>, Chaitanya Kulkarni <chaitanyak@...dia.com>
CC: "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"james_p_freyensee@...ux.intel.com" <james_p_freyensee@...ux.intel.com>,
	"jthumshirn@...e.de" <jthumshirn@...e.de>, "zhanjun@...ontech.com"
	<zhanjun@...ontech.com>, "niecheng1@...ontech.com" <niecheng1@...ontech.com>,
	"guanwentao@...ontech.com" <guanwentao@...ontech.com>,
	"chenlinxuan@...ontech.com" <chenlinxuan@...ontech.com>
Subject: Re: [PATCH] nvmet-fc: Remove unused functions

On 3/11/25 22:06, WangYuli wrote:
> The functions nvmet_fc_iodnum() and nvmet_fc_fodnum() are currently
> unutilized.
>
> Following commit c53432030d86 ("nvme-fabrics: Add target support for FC
> transport"), which introduced these two functions, they have not been
> used at all in practice.
>
> Remove them to resolve the compiler warnings.
>
> Fix follow errors with clang-19 when W=1e:
>    drivers/nvme/target/fc.c:177:1: error: unused function 'nvmet_fc_iodnum' [-Werror,-Wunused-function]
>      177 | nvmet_fc_iodnum(struct nvmet_fc_ls_iod *iodptr)
>          | ^~~~~~~~~~~~~~~
>    drivers/nvme/target/fc.c:183:1: error: unused function 'nvmet_fc_fodnum' [-Werror,-Wunused-function]
>      183 | nvmet_fc_fodnum(struct nvmet_fc_fcp_iod *fodptr)
>          | ^~~~~~~~~~~~~~~
>    2 errors generated.
>    make[8]: *** [scripts/Makefile.build:207: drivers/nvme/target/fc.o] Error 1
>    make[7]: *** [scripts/Makefile.build:465: drivers/nvme/target] Error 2
>    make[6]: *** [scripts/Makefile.build:465: drivers/nvme] Error 2
>    make[6]: *** Waiting for unfinished jobs....
>
> Fixes: c53432030d86 ("nvme-fabrics: Add target support for FC transport")
> Signed-off-by: WangYuli<wangyuli@...ontech.com>


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck