linux-kernel - Re: [PATCH] nvmet: pci-epf: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57568d96-74d4-4e48-93f8-4439ba18649e@nvidia.com>
Date: Wed, 12 Mar 2025 17:43:59 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Chen Ni <nichen@...as.ac.cn>, "hch@....de" <hch@....de>,
	"sagi@...mberg.me" <sagi@...mberg.me>, Chaitanya Kulkarni
	<chaitanyak@...dia.com>, "linux-nvme@...ts.infradead.org"
	<linux-nvme@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvmet: pci-epf: Remove redundant 'flush_workqueue()'
 calls

On 3/12/25 01:56, Chen Ni wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
>    destroy_workqueue(E);
>
> Signed-off-by: Chen Ni<nichen@...as.ac.cn>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck