linux-kernel - Re: [PATCH] Bluetooth: HCI: Fix value of HCI_ERROR_UNSUPPORTED_REMOTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABBYNZKSUmXvtc+bJ0aSh7ehHkePBA2Vqs1XUVwaa7H3M7eeaQ@mail.gmail.com>
Date: Wed, 12 Mar 2025 15:28:53 -0400
From: Luiz Augusto von Dentz <luiz.dentz@...il.com>
To: Si-Jie Bai <sy2239101@...a.edu.cn>
Cc: marcel@...tmann.org, johan.hedberg@...il.com, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, 
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, cuijianw@...a.edu.cn, sunyv@...a.edu.cn, 
	baijiaju@...a.edu.cn
Subject: Re: [PATCH] Bluetooth: HCI: Fix value of HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE

Hi Si-Jie,

On Wed, Mar 12, 2025 at 4:39 AM Si-Jie Bai <sy2239101@...a.edu.cn> wrote:
>
> HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE is actually 0x1a not 0x1e:
>
> BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 1, Part F
> page 371:
>
>   0x1A  Unsupported Remote Feature
>
> Signed-off-by: Si-Jie Bai <sy2239101@...a.edu.cn>
> ---
>  include/net/bluetooth/hci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 0d51970d8..3ec915738 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -683,7 +683,7 @@ enum {
>  #define HCI_ERROR_REMOTE_POWER_OFF     0x15
>  #define HCI_ERROR_LOCAL_HOST_TERM      0x16
>  #define HCI_ERROR_PAIRING_NOT_ALLOWED  0x18
> -#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE   0x1e
> +#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE   0x1a
>  #define HCI_ERROR_INVALID_LL_PARAMS    0x1e
>  #define HCI_ERROR_UNSPECIFIED          0x1f
>  #define HCI_ERROR_ADVERTISING_TIMEOUT  0x3c
> --
> 2.25.1

I tooked the following one over this since it better explains the
issue and had the Fixes tag:

https://patchwork.kernel.org/project/bluetooth/patch/20250312190943.152482-1-arkadiusz.bokowy@gmail.com/

-- 
Luiz Augusto von Dentz