linux-kernel - Re: [PATCH] Bluetooth: HCI: Fix value of HCI_ERROR_UNSUPPORTED_REMOTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c2626fa-d923-4ef8-a102-2d9413319110@molgen.mpg.de>
Date: Wed, 12 Mar 2025 09:54:01 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Si-Jie Bai <sy2239101@...a.edu.cn>
Cc: luiz.dentz@...il.com, marcel@...tmann.org, johan.hedberg@...il.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, horms@...nel.org, linux-bluetooth@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, cuijianw@...a.edu.cn,
 sunyv@...a.edu.cn, baijiaju@...a.edu.cn, Jonas Dreßler
 <verdre@...d.nl>
Subject: Re: [PATCH] Bluetooth: HCI: Fix value of
 HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE

[Cc: +Jonas Dreßler]

Dear Si-Jie,


Welcome to the mailing list, and thank you for your patch!

Am 12.03.25 um 09:38 schrieb Si-Jie Bai:
> HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE is actually 0x1a not 0x1e:
> 
> BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 1, Part F
> page 371:

The above length is 66 characters (< 72), and fits in one line.

>    0x1A  Unsupported Remote Feature
> 

Maybe add:

The value was probably changed by mistake, when defining the macro.

Please add a Fixes: tag. It should be:

Fixes: 79c0868ad65a ("Bluetooth: hci_event: Use HCI error defines 
instead of magic values")

> Signed-off-by: Si-Jie Bai <sy2239101@...a.edu.cn>
> ---
>   include/net/bluetooth/hci.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 0d51970d8..3ec915738 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -683,7 +683,7 @@ enum {
>   #define HCI_ERROR_REMOTE_POWER_OFF	0x15
>   #define HCI_ERROR_LOCAL_HOST_TERM	0x16
>   #define HCI_ERROR_PAIRING_NOT_ALLOWED	0x18
> -#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE	0x1e
> +#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE	0x1a
>   #define HCI_ERROR_INVALID_LL_PARAMS	0x1e
>   #define HCI_ERROR_UNSPECIFIED		0x1f
>   #define HCI_ERROR_ADVERTISING_TIMEOUT	0x3c

With the above fixes, you can add:

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul