linux-kernel - Re: [PATCH v2 00/13] mailbox: pcc: Fixes and cleanup/refactoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250312200532.67xkag3joatel6m4@bogus>
Date: Wed, 12 Mar 2025 20:05:32 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: Adam Young <admiyo@...eremail.onmicrosoft.com>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Adam Young <admiyo@...amperecomputing.com>,
	Sudeep Holla <sudeep.holla@....com>,
	Huisong Li <lihuisong@...wei.com>,
	Robbie King <robbiek@...ghtlabs.com>,
	Jassi Brar <jassisinghbrar@...il.com>,
	Andi Shyti <andi.shyti@...nel.org>, linux-i2c@...r.kernel.org,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>, linux-hwmon@...r.kernel.org,
	"Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v2 00/13] mailbox: pcc: Fixes and cleanup/refactoring

On Wed, Mar 12, 2025 at 02:04:51PM -0400, Adam Young wrote:
> The XGene patch did not apply on top of Linus's current tree. The other
> patches applied OK.
>

Yes Guenter had mentioned it in his review. I have it rebased locally [1]
but yet to push out v3 on the list.

> I only had to make one modification to my patch to remove the call to
> ‘pcc_mbox_ioremap’,  as it is performed in the pcc_mbox_request_channel call
> instead. With that change, my driver continues to work. I will submit
> another version here shortly.
>

Nice, I wasn't aware of the Ampere driver using ioremap. Is it posted on
the list ? Or are you saying you will post it soon.

Thanks for testing. Please provide tested-by for patch 1-8 if you are
happy with it.

> I like the direction that this change is pushing, making the mailbox layer
> the owner for other drivers.
>

Yes it was long due. I had changes in my WIP but was away when you changes
got merged. Otherwise I would have asked you to do some of the changes in
this series. My bad, couldn't review your patches unfortunately.

-- 
Regards,
Sudeep

[1] ihttps://git.kernel.org/sudeep.holla/h/b4/pcc_fixes_updates